Inconsistent bech32/hex address format in API calls

KidA001 · February 24, 2022, 4:12pm

I’m using the https://rpc.s0.t.hmny.io API to get transaction data from blocks. I use the hmyv2_getBlockByNumber to get top-level transaction data and then hmy_getLogs to LogEvents.

In responses from hmyv2_getBlockByNumber the to/from addresses are in the bech32 format (one...), but all addresses in the logs are hex (0x...).

Will this always be the case or does Harmony plan to convert all addresses to bech32 format?

Maffaz · February 24, 2022, 4:40pm

Not sure what the plans for the future are but I wrote a docker service to convert addresses.

The code for the conversion is here but you will also require the bech32.py module included or just boot up the service and call via API…

github.com

johnashu/harmony_convert_address/blob/main/src/app/core/convert.py

import re
from core.bech32 import *
from eth_utils import *
from Crypto.Hash import keccak

HRP = "one"


async def is_eth_checksum_address(address: str) -> bool:
    """Takes an Ethereum based address and checks that the checksum is valid

    Args:
        address (str): Eth Address

    Returns:
        bool: Result if valid or not.
    """
    address = address.replace("0x", "")
    address_hash = keccak.new(digest_bits=256)
    address_hash = address_hash.update(address.lower().encode("utf-8")).hexdigest()

This file has been truncated. show original

KidA001 · February 24, 2022, 5:19pm

Thank you. Converting it is no problem, I’m already doing that with this npm package. I’m just wondering if there will be breaking changes in the future. I don’t quite understand why top level addresses in the from/to of hmyv2_getBlockByNumber are bech32 but everything else is hex. We just convert to hex for our own sanity/ease

Maffaz · February 24, 2022, 5:39pm

I was just about to post the js version

I’m the same, don’t care what format but i generally stick to one or the other.

It would be nice to have some consistency api wise.

@giv @rongjian do we have any plans to align this in the future?

marku01 · February 25, 2022, 9:34pm

I haven’t tested this myself. But you can check if eth_/hmy_/hmyv2_ methods give different results. AFAIK that’s what they are intended for

Topic		Replies	Views
Convert Ethereum hex style address to bech32 via Javascript Web3	6	1158	March 21, 2022
ONE <> ETH Async Convert Address Service [Python / Docker] Web3	0	198	January 28, 2022
Convert_one_to_hex missing from python pyhmy? Developers	3	442	November 17, 2021
Why Harmony has a unique ONE address format? Community	2	209	November 25, 2021
ONE <> ETH Async Convert Address Service [Python] Web3	2	263	December 17, 2021

Inconsistent bech32/hex address format in API calls

Related topics